Skip to content

Receipt detail modal no longer opens on double-click after the Receipts↔Service-Invoices tab merger

Symptom

On the Records page (the merged "Receipts" tab → Expense Receipts sub-tab), double-clicking a row no longer opens the receipt detail modal. Reported by the owner, 2026-06-21 (verbatim):

"Why is it that I can no longer open the receipt detail modal upon double clicking it? The behavior has changed, can you possibly reverse it back to how it was (the tab has gone thru a merger with the Service invoice tab previously, that might have changed the behavior)"

Pre-merger behaviour: double-click opened ReceiptDetailDrawer (the row's editable detail panel). Post-merger behaviour: double-click does window.open(fileUrl, '_blank') — opens the raw PDF/image in a new browser tab instead.

Diagnosis

The Receipts↔Service-Invoices tab merger collapsed ReceiptsTab.tsx + VendorInvoicesTab.tsx into a single components/records/ExpenseRecordsTab.tsx. In that consolidation the detail-drawer wiring was dropped entirely:

  • Old ReceiptsTab.tsx:969-1011 — onDoubleClick: () => setActiveId(r.id) opened the drawer; the component imported ReceiptDetailDrawer and rendered it conditionally on activeId.
  • New ExpenseRecordsTab.tsx:427-435 (pre-fix) — onDoubleClick: () => window.open(r.fileUrl, '_blank', …). The file doesn't even import ReceiptDetailDrawer / VendorInvoiceDetailDrawer; the drawer was removed in the merge, not just rerouted to a different trigger.

So the symptom is the absence of the drawer wiring, not a bug in the drawer itself.

Escalation — T-087 (the structural fix)

Escalated 2026-06-21 to T-087. The fix re-introduces both drawers in ExpenseRecordsTab, routes double-click to setActiveId(r.id) (matching the old ReceiptsTab pattern), and keys the rendered drawer on the row's kind: - receipt → ReceiptDetailDrawer (by un-prefixed recordId) - service-invoice → VendorInvoiceDetailDrawer (lazily fetches the richer VendorInvoiceRow from /api/records/vendor-invoices and matches by recordId)

Raw-file open stays available via right-click → "Open file in new tab" + the per-row PDF button — nothing is lost.

2026-07-01 — fixed (via T-087)

Resolved via T-087 (done) — receipt detail modal re-opens on double-click. [owner: close I-004] - Source (edit): EOP Local Assistance (fork) · session edb0abc7-6373-449b-8e31-379fd38d391b